apollographql / apollographql/apollo-tooling

Node engine version changed outside of major version

Open
#2,395 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3k
Forks
460
PR merge metrics
No merged PRs in 30d

Description

A transitive dependency, @apollo/federation changed its `engines` field to drop Node 10, but there was not a corresponding Breaking Change on the `apollo` root package. Narrowing the supported version range for a package is not a semver-compatible change.

https://github.com/apollographql/federation/blob/main/federation-js/CHANGELOG.md#v0210

This is bit confusing with 0.x versions (any change to x can be breaking); I would suggest releasing the federation module as a 1.0.0 since it is widely installed in production.

Contributor guide

Open the contributing guide

Research direction

Start with the linked @apollo/federation CHANGELOG entry for v0.21.0 and inspect how the apollo root package records dependency engine changes. Determine the intended semver and breaking-change treatment for dropping Node 10; the work is done when the package metadata and release communication follow the agreed policy.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, typescript
Domain
release
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.