apollographql / apollographql/apollo-tooling
apollo service:check is not considering the commitId nor author params
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 460
- PR merge metrics
- No merged PRs in 30d
Description
**Intended outcome:**

**Actual outcome:**

**How to reproduce the issue:**
On any machine try to check the schema with `branch`, `author` and `commitId` params like bellow:
`apollo service:check --key=... --localSchemaFile=schema.graphql --commitId=33aaf0ad280f2f0214a287bb0e1a3a959cfd2461 --author="Mike Shinoda " --branch=feature-branch-name --variant=current`
Docs: https://github.com/apollographql/apollo-tooling#apollo-servicecheck
From those 3 params mentioned above, only `branch` is actually set on Apollo Studio, the `commitId` and `author` params are ignored.
I tried to explorer myself to understand what was causing the issue and I found out this was introduced on this PR: https://github.com/apollographql/apollo-tooling/pull/2156
**Versions**
- apollo/2.32.10
- darwin-x64
- node-v12.13.1
Contributor guide
Research direction
Start at the `apollo service:check` command and inspect PR #2156, which the report identifies as the likely source of the regression. Reproduce the command with `branch`, `author`, and `commitId`, then verify that all three values are sent to and recorded by Apollo Studio rather than only `branch`.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- graphql, typescript
- Domain
- api, cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100