apollographql / apollographql/apollo-tooling

Can the apollo-language-server moment version be unpinned?

Open
#1,999 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3k
Forks
460
PR merge metrics
No merged PRs in 30d

Description

Currently, in `apollo-language-server` the version of `moment` is pinned to `2.24.0`. This is causing our `npm i` to install two versions of `moment`, the latest that we use and `2.24.0` Can we unpin the moment version in `apollo-language-server`, or is it pinned for a reason?

Contributor guide

Open the contributing guide

Research direction

Inspect the dependency declaration for moment in apollo-language-server and check whether the 2.24.0 pin has a documented reason. Run npm i to compare the installed moment versions before and after the dependency change; done means the unnecessary duplicate version is no longer installed without breaking apollo-language-server.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
devtools
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.