apollographql / apollographql/apollo-tooling

Generated Flow type files should have `// @flow strict` pragma

Open
#1,576 0 comments 0 reactions 0 assignees View on GitHub
🤖 component - codegen
Dominant language
TypeScript
Stars
3k
Forks
460
PR merge metrics
No merged PRs in 30d

Description

Currently, if the generated files with Flow types have `/* @flow */` at the top of the file.

This should be changed to `// @flow strict` so that the types can be imported in other `strict` files without warning.

Thanks!

Contributor guide

Open the contributing guide

Research direction

Inspect the generator entry point that emits Flow-typed files and locate where the /* @flow */ header is produced. Change the generated pragma to // @flow strict, then verify the generated files can be imported by strict Flow files without warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.