apollographql / apollographql/apollo-tooling

RemoteUrl in git info seems to be incorrectly formatted

Open
#1,064 1 comment 0 reactions 0 assignees View on GitHub
✔ confirmed 🐞 bug 🙏 help-wanted
Dominant language
TypeScript
Stars
3k
Forks
460
PR merge metrics
No merged PRs in 30d

Description

This was raised by a comment on #826

**Intended outcome:**

The remoteUrl in the gitInfo function has the remote repository url.

**Actual outcome:**

Depending on where in the file you are, it may be defined as a `slug` (`apollographql/apollo-tooling`)

https://github.com/apollographql/apollo-tooling/blob/master/packages/apollo/src/git.ts#L52

or the remote url (`https://github.com/apollographql/apollo-tooling`)

https://github.com/apollographql/apollo-tooling/blob/master/packages/apollo/src/git.ts#L74

**How to reproduce the issue:**

Console log the values while running in a CI

Contributor guide

Open the contributing guide

Research direction

Start in packages/apollo/src/git.ts at the referenced lines 52 and 74, and compare how gitInfo defines remoteUrl in each location. Reproduce by logging the values while running in CI. Done means remoteUrl consistently contains the remote repository URL rather than a repository slug.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, typescript
Domain
cli, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.