apollographql / apollographql/apollo-server

Add a test showing http/2 works

Open
#6,992 5 comments 0 reactions 0 assignees View on GitHub
📚 good-first-issue 🙏 help-wanted 🧪 testing
Dominant language
TypeScript
Stars
14k
Forks
2k
Avg merge
5h 30m
Merged PRs (30d)
1

Description

Apollo Server v3 used `node-fetch` `Request`s to represent incoming requests, and those objects aren't compatible with http/2 requests which have colons in header names. See #2333 and #1533.

We think that AS4 (which no longer uses that representation for requests) should support http/2. It would be great to get a PR adding a test!

Contributor guide

Open the contributing guide

Research direction

Start by locating Apollo Server 4's existing HTTP integration tests and the entry point that handles incoming requests. Add coverage for an HTTP/2 request, then run the relevant test suite and confirm the request completes successfully without the header-name incompatibility described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
api, backend, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.