apigee / apigee/apigeetool-node

New proxies created in Apigeetool are not automatically added to custom roles for edit

Open
#36 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
91
Forks
91
PR merge metrics
No merged PRs in 30d

Description

Background:
Create 2 users (user 1 and user 2) in custom role. The custom role has CREATE and VIEW abilities on all API proxies.

+Scenario 1 (this works as expected):+

  1. With user 1, create a new proxy in UI.
  2. Note that the new proxy is automatically added to the custom role in which the user belongs. The permissions include View, Edit and Delete, as well as Deploy on the new proxy.
  3. Now user 2 logs into UI and can edit the newly created proxy that was created by user 1.

+Scenario 2 (this fails)+

  1. With user 1, create a new proxy using Apigee tool (https://github.com/apigee/apigeetool-node#deployproxy)
  2. Note that you get a 403 forbidden back, but the proxy is still created. This is not the point of failure for this JIRA ticket (filed separately in APIRT-2122).
  3. Now user 2 logs into UI and CANNOT edit the newly created proxy that was created by user 1. The problem is that the new proxy is not automatically added to the custom role with the correct permissions (The permissions include View, Edit and Delete, as well as Deploy on the new proxy).

I think it is a bad user experience if the UI takes care of creating this entry in the custom role(prob via an additional MS API call), but Apigeetool does not. IMO these 2 tools should be at parity for this feature since both are officially supported by Apigee.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the deployproxy entry point in the Apigeetool Node.js repository and trace how proxy creation handles custom-role permissions. Compare the tool's behavior with the UI scenario described, then verify that a newly created proxy is added with View, Edit, Delete, and Deploy permissions for the custom role.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.