api7 / api7/lua-resty-saml

feat: return exception status and info

Open
#12 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Perl
Stars
2
Forks
3
Avg merge
2d 20h
Merged PRs (30d)
3

Description

The lua-resty-saml implies a lot of ngx.exit() in codes for exception cases.
Instead, the exit code and related info should be returned to authenticate() caller.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the exception paths that call ngx.exit() and the authenticate() entry point. Determine which exit status and related information each path must return to the caller. Done means exception cases no longer exit directly and authenticate() consistently exposes the required status and info, with tests covering those paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
authentication, backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.