api7 / api7/apisix-nginx-module
refactor: remove dependence on apisix-base
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 45
- Forks
- 25
- Avg merge
- 1h 34m
- Merged PRs (30d)
- 1
Description
The dependency should be apisix-base depends on apisix-nginx-module.
build-apisix-base.sh --> apisix-nginx-module
So we should not use build-apisix-base.sh in CI https://github.com/api7/apisix-nginx-module/blob/1345603d3b04b027cdae8254877af64f753ea7f3/.github/workflows/ci.yml#L41
A better way is to refer to CI of lua-resty-core to add a new script only for apisix-nginx-module. ref: https://github.com/openresty/lua-resty-core/blob/dc3fdd91b1abc2aac6706c9117a99cd2e00e6133/.travis.yml#L65
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/workflows/ci.yml at the referenced line and trace how build-apisix-base.sh is used in CI. Compare the lua-resty-core .travis.yml reference and determine the new apisix-nginx-module-only script; done means CI no longer depends on apisix-base or build-apisix-base.sh.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, shell
- Domain
- ci-cd
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100