api7 / api7/apisix-nginx-module
The current request header change detection doesn't work well with subrequest
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 45
- Forks
- 25
- Avg merge
- 1h 34m
- Merged PRs (30d)
- 1
Description
The current change detection only marks the current request, but not the main request if the current request is subrequest:
https://github.com/api7/apisix-nginx-module/blob/1af1ee48b06d1acc58fd2ca15fd27541953f57f9/src/ngx_http_apisix_module.c#L565
However, the headers_in field is shared between subrequest and the main request.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/ngx_http_apisix_module.c at the change-detection logic around line 565, then read how nginx represents main requests and subrequests and how headers_in is shared. Done means a header change made during a subrequest also marks the main request appropriately; the issue does not name a test to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, nginx
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100