api7 / api7/apisix-nginx-module
dynamic settings may fail when slice involving
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 45
- Forks
- 25
- Avg merge
- 1h 34m
- Merged PRs (30d)
- 1
Description
Hello! @spacewander
Since https://hg.nginx.org/nginx/rev/d16ba0ea3434 ，
Subrequests of slice module will bypass phases which come before content handler, and may trigger some confusing behaviors for some dynamic settiings, especialy proxy settings. For example https://github.com/api7/apisix-nginx-module/pull/35 .
The safe way maybe set the according attributes of ngx_http_apisix_ctx_t again to ctx->sr right after ngx_http_subrequest in ngx_http_slice_filter_module.c .
It's not a bug report, just a mention.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in ngx_http_slice_filter_module.c and inspect the ngx_http_subrequest call alongside ngx_http_apisix_ctx_t and its sr context. Compare the behavior described after nginx revision d16ba0ea3434 and the related pull request; done means the relevant dynamic settings remain correct for slice subrequests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100