api7 / api7/api7-ingress-controller

fix: supportsEndpointSlice needs to be set correctly

Open
#349 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
5
Forks
5
Avg merge
2d 7h
Merged PRs (30d)
10

Description

It is necessary to determine whether the call here is accurate. In subsequent functions, resolveServiceEndpoints(tctx, c, serviceNN, true, nil)

the param supportsEndpointSlice We set it to true by default, which theoretically would cause problems on k8s clusters that do not support EndpointSlice

Originally posted by @ronething in #220

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing calls to resolveServiceEndpoints(tctx, c, serviceNN, true, nil) and how supportsEndpointSlice is determined. Check Kubernetes compatibility handling for clusters without EndpointSlice support; done means the parameter is set accurately and the affected endpoint resolution behavior is covered by the repository's existing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.