api-platform / api-platform/schema-generator

[enhancement] don't make abstract classes and embeddables api resources

Open
#72 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
474
Forks
107
PR merge metrics
No merged PRs in 30d

Description

Right now if I have this `schema.yml`

```yaml
types:
Thing:
properties:
name: ~

Person:
properties:
familyName: ~

Country:
parent: false
embeddable: true
properties:
address: { range: "Text" }

PostalAddress:
parent: false
properties:
addressCountry: { range: "Country", embedded: true }
```

It will generate all the entities and all entities are marked as an api resource in the class annotations. The only problem is that you don't want `Thing` and `Country` to be api resources. `Thing` is an abstract class so it can't even be initialized. And since `Country` is an embeddable it isn't linked to any database table so you can never fetch any countries from the api.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.