aperture-data / aperture-data/aperturedb-python

Redact sensitive tokens in query objects when logging errors

Open
#707 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
13
Forks
4
PR merge metrics
No merged PRs in 30d

Description

When logging partial errors or exceptions in CommonLibrary.py and elsewhere, the raw query object is sometimes serialized and logged (e.g. json.dumps(query)). If the query contains token, refresh_token, or other credentials, they may leak in the logs.
We should apply censor_tokens() (or a similar redaction method) to the query objects before logging them.
This was noted during the review of PR #672.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review CommonLibrary.py and the other error-logging call sites referenced by the issue, starting with the existing censor_tokens() usage. Use PR #672 for review context, and verify that token-bearing query objects are redacted before serialization in partial-error and exception logs.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.