apereo / apereo/phpCAS

Filter X-Forwarded header in _getServerUrl()

Open
#49 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement
Dominant language
PHP
Stars
798
Forks
419
PR merge metrics
No merged PRs in 30d

Description

The valid proxies and loadbalancers that are put in front of a phpcas application should be filtered. Related to #45

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating _getServerUrl() and read the context of related issue #45. Determine how valid proxies and load balancers should be identified before accepting X-Forwarded header values. Done means forwarded information is filtered according to that proxy policy, with the behavior verified by appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.