Differentiate ErrorException from GracefullTerminationException
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 798
- Forks
- 419
- PR merge metrics
- No merged PRs in 30d
Description
In our application we initialize the CAS Client together with calling CAS_GracefullTerminationException::throwInsteadOfExiting() method and then we handle exceptions in our own fashion.
Right now the same exception CAS_GracefullTerminationException is used when the library ends its work and when there is a real error reported by a phpCAS::error() method.
I think it would be helpful for the integrators, to use a different exception for errors reported in the phpCAS::error() method.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing CAS_GracefullTerminationException::throwInsteadOfExiting() and the phpCAS::error() path mentioned in the issue. Done means errors from phpCAS::error() use a distinct exception while normal library termination continues to use CAS_GracefullTerminationException; the payload names no files or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100