apereo / apereo/phpCAS

beginTrace/endTrace optimization

Open
#343 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement
Dominant language
PHP
Stars
798
Forks
419
PR merge metrics
No merged PRs in 30d

Description

There seems to be a lot of code called in beginTrace for no reason, when debugging is turned off. That's assuming I'm not missing anything,

But even with debugging turned off, debug_backtrace and other functions are called regardless, if debugging/logging is on or off. Would it make sense for this to be a simple bool check wrapped around the begin and end trace.

Is this really needed in production, I've found it useful, especially with pgt issues, but I wonder if there are other methods that would prove more useful?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating beginTrace and endTrace and examining their calls to debug_backtrace and related tracing functions. Compare behavior and overhead with debugging and logging disabled versus enabled. Done means unnecessary trace work is avoided when disabled without changing enabled tracing behavior, supported by relevant tests or measurements.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication, performance
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.