apache / apache/uniffle

[Improvement] Support setting the BASE_IMAGE of the BASE_IMAGE when building a container using build.sh

Open Beginner friendly
#952 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
454
Forks
172
Avg merge
5d 17h
Merged PRs (30d)
5

Description

### Code of Conduct

- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)

### Search before asking

- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.

### What would you like to be improved?

In build.sh when BASE_IMAGE is not passed a new base image is built. This base image definition under "base/"${OS_DISTRIBUTION}"/Dockerfile" also takes an argo BASE_IMAGE. If users want to build under different java base images than the default "eclipse-temurin:11-jdk" this is currently not possible in this script.

That functionality would be useful.

### How should we improve?

Add a new arg BASE_IMAGE_BASE to build.sh that defaults to 'eclipse-temurin:11-jdk' that is passed to the build of the BASE_IMAGE

### Are you willing to submit PR?

- [X] Yes I am willing to submit a PR!

Contributor guide

Open the contributing guide

Research direction

Start by reading build.sh and the base/OS_DISTRIBUTION/Dockerfile referenced in the issue to trace how the base image is built. Run the container build with the default and a custom Java base image; done means both paths work and the default remains eclipse-temurin:11-jdk.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, java, shell
Domain
build-system, devops
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.