[Improvement] Should we remove `taskAttemptId` in FileBasedShuffleSegment
- Dominant language
- Java
- Stars
- 454
- Forks
- 172
- Avg merge
- 5d 17h
- Merged PRs (30d)
- 5
Description
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
### What would you like to be improved?
We can calculate the taskAttemptId from the blockId, so should we remove it?
https://github.com/apache/incubator-uniffle/blob/66c752fe3ecd6d4979d3539fe22265d4239156a9/storage/src/main/java/org/apache/uniffle/storage/common/FileBasedShuffleSegment.java#L30
### How should we improve?
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
Contributor guide
Research direction
Start with storage/src/main/java/org/apache/uniffle/storage/common/FileBasedShuffleSegment.java at the linked line, then read the issue discussion and trace how taskAttemptId is derived from blockId. Determine whether removing it affects callers or related tests; done means the redundant value and its usages are removed without changing shuffle-segment behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- distributed-systems
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100