apache / apache/uniffle

[FEATURE] Add NettyMemoryMetrics for netty client and server

Open
#2,076 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
454
Forks
172
Avg merge
5d 17h
Merged PRs (30d)
5

Description

### Code of Conduct

- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)

### Search before asking

- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.

### Describe the feature

We should include `NettyMemoryMetrics` to enhance memory metrics for `PooledByteBufAllocator`. https://github.com/apache/spark/blob/master/common/network-common/src/main/java/org/apache/spark/network/util/NettyMemoryMetrics.java

### Motivation

_No response_

### Describe the solution

_No response_

### Additional context

_No response_

### Are you willing to submit PR?

- [X] Yes I am willing to submit a PR!

Contributor guide

Open the contributing guide

Research direction

Start by reading Spark's NettyMemoryMetrics implementation at the linked common/network-common/src/main/java/org/apache/spark/network/util/NettyMemoryMetrics.java and compare how this project creates its PooledByteBufAllocator for clients and servers. Done means equivalent memory metrics are included for both Netty client and server allocators.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.