apache / apache/uniffle

[Bug] Incorrect stage retry condition for fetch failure

Open
#1,801 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
454
Forks
172
Avg merge
5d 17h
Merged PRs (30d)
5

Description

### Code of Conduct

- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)

### Search before asking

- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.

### Describe the bug

In current codebase, the retry will happen when the partitionId's failure reaches the `spark.task.maxFailures`. At the case of no-AQE, this is right. But for AQE, this suppose is wrong.

### Affects Version(s)

master

### Uniffle Server Log Output

_No response_

### Uniffle Engine Log Output

_No response_

### Uniffle Server Configurations

_No response_

### Uniffle Engine Configurations

_No response_

### Additional context

_No response_

### Are you willing to submit PR?

- [ ] Yes I am willing to submit a PR!

Contributor guide

Open the contributing guide

Research direction

Start by tracing the retry condition for partitionId fetch failures in the current codebase, using spark.task.maxFailures as the reference for non-AQE behavior and comparing it with AQE execution. Confirm the expected retry behavior for both AQE and no-AQE cases, then add or update regression coverage so the corrected condition is verifiable.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spark
Domain
backend, distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.