apache / apache/uniffle

[Improvement] Introduce HybridRpcServer to implement ServerInterface for GRPC_NETTY

Open
#1,354 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
454
Forks
172
Avg merge
5d 17h
Merged PRs (30d)
5

Description

### Code of Conduct

- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)

### Search before asking

- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.

### What would you like to be improved?

Currently, the streamServer of netty and grpc server are created in the different places. From my prospective, we could introduce HybridRpcServer to implement ServerInterface for GRPC_NETTY.

In the HybridRpcServer, the grpc and netty should be started.

### How should we improve?

_No response_

### Are you willing to submit PR?

- [X] Yes I am willing to submit a PR!

Contributor guide

Open the contributing guide

Research direction

Start by tracing where the Netty streamServer and gRPC server are currently created, then inspect ServerInterface and the GRPC_NETTY path. The proposed HybridRpcServer should implement ServerInterface and start both servers; verify its lifecycle and integration with the existing startup flow.

Written by the indexing model from the issue text.

Assessment

Tech stack
grpc, java
Domain
backend, distributed-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.