apache / apache/tsfile

Optimize TsFileWriter::do_check_schema CPU overhead for repeated wide-tablet writes

Open
#885 1 comment 0 reactions 0 assignees View on GitHub
performance
Dominant language
Java
Stars
203
Forks
104
Avg merge
2d 6h
Merged PRs (30d)
33

Description

## Problem

`TsFileWriter::do_check_schema` shows noticeable CPU overhead when writing repeated tablets with the same device and schema.

In our workload, each writer repeatedly writes tablets for a fixed device with a fixed set of measurements. However,
`write_tablet()` calls `do_check_schema()` for every tablet write. This appears to repeatedly perform schema lookup and
measurement-name matching even though the schema has already been registered and does not change during the file lifecycle.

## Evidence

Using Windows Performance Analyzer on a 60-second TsFile archive workload, the active processing window showed:

- `TsFileArchive.dll!storage::TsFileWriter::do_check_schema` as the top TsFileArchive function
hotspot
- `std::string::compare` also appeared as a related hotspot
- The workload writes tablets with the same device and the same schema repeatedly
- TsFile writing took longer than the input data duration

Example hotspot:

```text
TsFileArchive.dll!storage::TsFileWriter::do_check_schema
```
## Suspected Cause

write_tablet() creates or looks up schema information on every call:

- creates a StringArrayDeviceID from tablet.insert_target_name_
- looks up the device in schemas_
- iterates all measurement names
- looks up each measurement in measurement_schema_map_
- fills chunk_writers and data_types

For wide tablets and high-frequency writes, this repeated per-tablet schema validation becomes expensive.

## Suggested Optimization

Add a cached or prepared schema path for repeated tablet writes.

Possible approaches:

1. Cache the resolved schema for the last used device/tablet schema inside TsFileWriter.
2. Add an explicit prepared API, for example:

PreparedTabletSchema prepare_tablet_schema(device_id, schema_vec);
int write_tablet_prepared(const Tablet& tablet, const PreparedTabletSchema& prepared);

The cached/prepared data could include:

- MeasurementSchemaGroup*
- resolved ChunkWriter* list
- resolved TSDataType list

This would allow repeated writes with the same device and schema to skip per-column name lookup.

## Expected Benefit

Reduce CPU overhead in high-throughput TsFile writing workloads, especially for wide schemas where the same tablet schema is
written repeatedly.

## Notes

This should preserve the existing validation behavior for dynamic schemas or changing devices. The optimization can be limited
to cache hits where both device and schema identity match.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at TsFileWriter::write_tablet() and do_check_schema, tracing the device and measurement-schema lookups and the chunk_writers and data_types resolution described in the issue. Compare repeated identical-device writes with changing-device or dynamic-schema writes; done means reducing repeated lookup overhead while preserving existing validation behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
data, performance
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.