apache / apache/texera

Remove two commented-out test blocks from the workflow editor spec

Open
#8,461 0 comments 0 reactions 1 assignee Claimed by @aglinxinyuan View on GitHub
Dominant language
Scala
Stars
314
Forks
187
Avg merge
1d 21h
Merged PRs (30d)
214

Description

### Task Summary

`workflow-editor.component.spec.ts` carries two large commented-out test blocks. Neither can be re-enabled as written, and both have live replacement coverage.

### History

| | |
| --- | --- |
| **Block at 708-822** (copy/cut/paste) | commented out when written, by #1619 (2022-09-13, "Copy and Paste Operators with System Clipboard") — the header says the new clipboard path "would not pass this unit test, since write access to the system clipboard is needed". Superseded by the live `describe("clipboard")` block in this same file, which covers all three cases, plus a live paste-offset test in `operator-menu.service.spec.ts` |
| **Block at 531-638** (`xdescribe("when executionStatus is enabled")`) | commented out on 2020-08-01 (`a9c404764a`) — about six years. Cannot be revived: it spies on `changeOperatorStates` and `OperatorStates` (plural), while the live code has `changeOperatorState` and `OperatorState` (singular), and it calls `TestBed.get`, an API Angular has since removed |

Neither block is executable: verified by re-parsing the file with the repo's own TypeScript, which finds zero live tokens in either range, so neither registers with Vitest.

Pure deletion, no behaviour change: −225 lines.

### Task Type

- [x] Refactor / Cleanup

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.