apache / apache/solr-operator

not every ingress controller is nginx

Open
#725 1 comment 0 reactions 0 assignees View on GitHub
cloud networking
Dominant language
Go
Stars
283
Forks
148
PR merge metrics
No merged PRs in 30d

Description

https://github.com/apache/solr-operator/blob/630efa053f88333587ca6eeca94887aa2a65f61b/controllers/util/solr_util.go#L1088-L1104

Although this is pretty harmless as noise I'm not sure why this assumption was hard-coded in.

Can you consider adding if customOptions.IngressClassName == "nginx" or similar?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in controllers/util/solr_util.go around lines 1088-1104 and inspect how customOptions.IngressClassName is used when the ingress controller assumption produces noise. Confirm the intended condition for nginx versus custom ingress classes; done means the assumption is no longer applied to non-nginx ingress controllers.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.