apache / apache/shenyu

[Task] — Storage compose scripts: no `set -e`, no trap, hardcoded sleeps

Open
#6,818 1 comment 0 reactions 0 assignees View on GitHub
priority: medium type: build
Dominant language
Java
Stars
8.8k
Forks
3.1k
Avg merge
7d 1h
Merged PRs (30d)
85

Description

- severity: Medium; files: same four `e2e-*-compose.sh` storage scripts
- description: No `set -euo pipefail` (the `http` compose script has it; these don't). No `trap` to run `docker compose down` on failure/exit. Uses `sleep 30s` then `sleep 60s` instead of polling for healthy.
- impact: A failed `storage_init_*.sh` or `docker compose up` is silently ignored; services left running after the job.
- suggested_fix: Add `set -euo pipefail`; add `trap 'docker compose -f ... down' EXIT`; replace `sleep` with a poll-until-healthy loop.
- confidence: High

---
_Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/06-medium-tiers.md`](docs/scan2-2026-08-02/06-medium-tiers.md)._

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by comparing the four storage e2e-*-compose.sh scripts with the HTTP compose script, then inspect the referenced storage_init_*.sh commands and the scan notes in docs/scan2-2026-08-02/06-medium-tiers.md. Run the storage compose scripts to verify failures stop the job, cleanup runs on exit, and service readiness is polled rather than governed by fixed sleeps.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker-compose, shell
Domain
devops, infrastructure, testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.