apache / apache/shenyu

[BUG] — Dubbo & Sofa reference caches: `key.contains(id)` substring invalidation → mass spurious rebuilds + O(n) full scan per event

Open
#6,798 1 comment 0 reactions 0 assignees View on GitHub
priority: medium type: performance
Dominant language
Java
Stars
8.8k
Forks
3.1k
Avg merge
7d 1h
Merged PRs (30d)
85

Description

- severity: Medium-High
- files: `shenyu-plugin-.../apache-dubbo/.../cache/ApacheDubboConfigCache.java:531-536` (`invalidateWithSelectorId`), `:543-548` (`invalidateWithRuleId`), `:555-560` (`invalidateWithMetadataId`); `.../sofa/.../cache/ApplicationConfigCache.java:436-467`
- description: Cache keys are composite `namespace_selectorId_ruleId_metaDataId_protocol__version_group`. Invalidation matches `key.contains(id)` as a *substring*; a short numeric/UUID id (or common hex chars in the md5 segment) can legitimately match unrelated keys. Each spurious invalidation triggers `cache.invalidate` → `removalListener` → `config.destroy()`, so the next request forces a full `reference.get()`/`refer()` rebuild (expensive registry connect) on the request hot path. Worst case (id `1`, `0`) → mass invalidation. Also an O(n) full scan of `cache.asMap().keySet()` on every sync event.
- impact: Sync event → request hot-path rebuild storm; event-loop stalls during registry reconnect (see PERF-51).
- suggested_fix: Invalidate by exact composite-key segment (split key on separator and compare the specific segment), or maintain a secondary index `id -> Set` for O(1) exact invalidation.
- confidence: High

---
_Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/06-medium-tiers.md`](docs/scan2-2026-08-02/06-medium-tiers.md)._

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with invalidateWithSelectorId, invalidateWithRuleId, and invalidateWithMetadataId in ApacheDubboConfigCache.java, then compare the corresponding logic in ApplicationConfigCache.java. Trace the composite cache-key format and sync-event path before choosing exact segment matching or a secondary index. Done means unrelated keys remain valid, invalidation avoids the full key scan, and affected references rebuild only when their own identifiers match.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.