apache / apache/shenyu

[BUG] TarsMetaDataHandler dedup comparison is semantically wrong (host vs appName)

Open
#6,738 1 comment 0 reactions 0 assignees View on GitHub
plugin: tars priority: medium type: bug
Dominant language
Java
Stars
8.8k
Forks
3.1k
Avg merge
7d 1h
Merged PRs (30d)
85

Description

- severity: Medium
- files: `shenyu-plugin/shenyu-plugin-proxy/shenyu-plugin-rpc/shenyu-plugin-tars/src/main/java/org/apache/shenyu/plugin/tars/handler/TarsMetaDataHandler.java:44-49`
- description: `handle` decides whether to (re)initialize by `prxList.stream().anyMatch(prx -> prx.getHost().equals(metaData.getAppName()))`. But `TarsInvokePrx.host` is set to `upstream.getUpstreamUrl()` (e.g. `1.2.3.4:1080`), while the compared value is `metaData.getAppName()` (e.g. `HelloApp`). These never match, so `exist` is always false and `initPrx` is invoked on every metadata handle event.
- impact: Every tars metadata sync triggers a redundant `initPrx` → `refreshTarsInvokePrxList`, amplifying TARS-02's race window.
- suggested_fix: Compare against a field that actually holds the app name, or store the app name on `TarsInvokePrx`.
- confidence: Medium
- related_existing: none

---
_Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/06-medium-tiers.md`](docs/scan2-2026-08-02/06-medium-tiers.md)._

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at shenyu-plugin/shenyu-plugin-proxy/shenyu-plugin-rpc/shenyu-plugin-tars/src/main/java/org/apache/shenyu/plugin/tars/handler/TarsMetaDataHandler.java:44-49 and trace handle through initPrx and refreshTarsInvokePrxList. Inspect TarsInvokePrx to identify the field that represents the app identity; done means repeated metadata handling recognizes an existing proxy instead of redundantly reinitializing it.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, distributed-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.