apache / apache/shenyu

[BUG] Boolean tars parameter parsed via Byte.valueOf → NumberFormatException

Open Beginner friendly
#6,736 1 comment 0 reactions 0 assignees View on GitHub
plugin: tars priority: medium type: bug
Dominant language
Java
Stars
8.8k
Forks
3.1k
Avg merge
7d 1h
Merged PRs (30d)
85

Description

- severity: Medium
- files: `shenyu-plugin/shenyu-plugin-proxy/shenyu-plugin-rpc/shenyu-plugin-tars/src/main/java/org/apache/shenyu/plugin/tars/util/PrxInfoUtil.java:67-72`
- description: The `boolean` PrimitiveType converter does `if (o instanceof String) { return Byte.valueOf((String) o); }`. For a boolean supplied as `"true"`/`"false"`, `Byte.valueOf("true")` throws `NumberFormatException`. Copy-paste from the `byte` converter (line 61-66); should be `Boolean.valueOf`/`Boolean.parseBoolean`.
- impact: Any tars method with a `boolean` parameter whose value arrives as a string fails with 500.
- suggested_fix: Replace `Byte.valueOf((String) o)` with `Boolean.valueOf((String) o)`.
- confidence: High
- related_existing: none

---
_Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/06-medium-tiers.md`](docs/scan2-2026-08-02/06-medium-tiers.md)._

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in shenyu-plugin/shenyu-plugin-proxy/shenyu-plugin-rpc/shenyu-plugin-tars/src/main/java/org/apache/shenyu/plugin/tars/util/PrxInfoUtil.java at lines 67-72, and compare the boolean converter with the byte converter at lines 61-66. Verify that string values "true" and "false" are handled without NumberFormatException; the issue is done when boolean TARS parameters supplied as strings no longer produce a 500.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
82/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.