apache / apache/shenyu

[BUG] app_auth.updateSelective WHERE clause omits namespace_id (cross-namespace update)

Open Beginner friendly
#6,690 1 comment 0 reactions 0 assignees View on GitHub
admin priority: medium type: bug
Dominant language
Java
Stars
8.8k
Forks
3.1k
Avg merge
7d 1h
Merged PRs (30d)
85

Description

- severity: Medium
- files: `shenyu-admin/src/main/resources/mappers/app-auth-sqlmap.xml:265-291` (updateSelective `WHERE id=#{id}`) vs `:251-263` (full `update` `WHERE id=#{id} AND namespace_id=#{namespaceId}`)
- description: The full `update` scopes by `id AND namespace_id`, but `updateSelective` (the path used by `AppAuthServiceImpl.createOrUpdate`) scopes only by `id` (verified). A caller that supplies an `id` belonging to namespace A can mutate an app_auth row from namespace B without a namespace match.
- impact: Potential cross-namespace tampering of app_auth when only an id is supplied and the namespace is not re-verified.
- suggested_fix: Add `AND namespace_id = #{namespaceId, jdbcType=VARCHAR}` to `updateSelective`'s WHERE.
- confidence: Medium
- related_existing: none. The baseline AppAuth issues (#6538-6540) are about updateDetail full-update nulling and path appName; this is the updateSelective WHERE clause.

---
_Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/06-medium-tiers.md`](docs/scan2-2026-08-02/06-medium-tiers.md)._

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with shenyu-admin/src/main/resources/mappers/app-auth-sqlmap.xml:265-291 and compare updateSelective with the full update at lines 251-263. Trace AppAuthServiceImpl.createOrUpdate to confirm the selective path and verify that an id from another namespace cannot be updated without a matching namespace_id.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, sql
Domain
authorization, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
74/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.