apache / apache/shenyu

[Task] — K8s ingress parsers & `IngressReconciler` have zero test

Open
#6,679 2 comments 0 reactions 0 assignees View on GitHub
in: test priority: high type: refactor
Dominant language
Java
Stars
8.8k
Forks
3.1k
Avg merge
7d 1h
Merged PRs (30d)
85

Description

- severity: High; files: `shenyu-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/reconciler/IngressReconciler.java:79`, `.../k8s/parser/IngressParser.java:40`, `.../parser/DivideIngressParser.java:69`, `.../parser/DubboIngressParser.java`, `.../parser/GrpcParser.java`, `.../parser/SofaParser.java`, `.../parser/WebSocketParser.java`, `.../parser/ContextPathParser.java`
- description: The 4 sibling reconcilers (`Endpoints`, `DivideIngress`, `WebSocket`, `Dubbo`) ARE tested, but all parsers and `IngressReconciler` itself are untested. These translate `V1Ingress` → ShenYu selector/rule.
- suggested_fix: Add `IngressReconcilerTest` + parser tests.

---
_Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/00-consolidated-critical-high.md`](docs/scan2-2026-08-02/00-consolidated-critical-high.md)._

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the existing tests for the Endpoints, DivideIngress, WebSocket, and Dubbo reconcilers, then read IngressReconciler.java and the listed parser classes. Add IngressReconcilerTest and parser tests covering their V1Ingress-to-ShenYu selector/rule translation, and run the Kubernetes controller test suite to verify the coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, kubernetes
Domain
backend, testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.