apache / apache/shenyu

[BUG] ThreadPoolExecutor never shut down in close0 for Huawei, Tencent, and Aliyun SLS clients

Open Beginner friendly
#6,654 1 comment 0 reactions 0 assignees View on GitHub
priority: high type: bug
Dominant language
Java
Stars
8.8k
Forks
3.1k
Avg merge
7d 1h
Merged PRs (30d)
85

Description

- severity: High
- files: `shenyu-plugin/shenyu-plugin-logging/shenyu-plugin-logging-huawei-lts/src/main/java/org/apache/shenyu/plugin/huawei/lts/client/HuaweiLtsLogCollectClient.java:103,117-126`; `.../shenyu-plugin-logging-tencent-cls/.../TencentClsLogCollectClient.java:93,112-121`; `.../shenyu-plugin-logging-aliyun-sls/.../AliyunSlsLogCollectClient.java:96,114-120`
- description: Each client creates a `ThreadPoolExecutor` (`threadExecutor`) in `initClient0()` for `Futures.addCallback(...)`. `close0()` only shuts down the producer/client and never calls `threadExecutor.shutdown()`. `AbstractLogConsumeClient.initClient()` calls `close()` before re-init, so every config refresh leaks the old thread pool's threads.
- impact: Thread leak on every config refresh or plugin re-init; eventually `RejectedExecutionException` and no log delivery.
- suggested_fix: Add `threadExecutor.shutdown()` to each `close0()`.
- confidence: High
- related_existing: none

---
_Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/00-consolidated-critical-high.md`](docs/scan2-2026-08-02/00-consolidated-critical-high.md)._

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with initClient0() and close0() in HuaweiLtsLogCollectClient.java, TencentClsLogCollectClient.java, and AliyunSlsLogCollectClient.java at the referenced lines, then read AbstractLogConsumeClient.initClient() to understand the re-initialization path. Ensure each close0() shuts down its threadExecutor, and verify that configuration refreshes no longer retain the old executor threads.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
observability-sre
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.