apache / apache/shenyu

[BUG] RoleServiceImpl.delete has no cascade to permission/user_role and no guard against deleting the super role

Open
#6,621 1 comment 0 reactions 0 assignees View on GitHub
admin: permission priority: high type: bug
Dominant language
Java
Stars
8.8k
Forks
3.1k
Avg merge
7d 1h
Merged PRs (30d)
85

Description

- severity: High
- files: `shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/RoleServiceImpl.java:126-133`
- description: `delete` only calls `roleMapper.delete(ids)`. It never removes `permission` rows whose `object_id` is the deleted role id (`permission.deleteByObjectIds` exists but is unused here) nor `user_role` rows whose `role_id` is deleted. Additionally, `role.selectById` filters `role_name != 'super'` but `selectByIds` (used at line 128) and `delete` do NOT, so the service can delete the `super` role.
- impact: Orphaned `permission` and `user_role` rows persist after role deletion, corrupting the permission graph; ability to delete the super role breaks admin access entirely.
- suggested_fix: In `RoleServiceImpl.delete`, reject ids whose role_name is 'super' (mirror `selectById`'s guard), then call `permissionMapper.deleteByObjectIds(ids)` and `userRoleMapper` delete-by-role-id before `roleMapper.delete`. Wrap in `@Transactional`.
- confidence: High
- related_existing: none.

---
_Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/00-consolidated-critical-high.md`](docs/scan2-2026-08-02/00-consolidated-critical-high.md)._

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/RoleServiceImpl.java:126-133 and compare delete with selectById's super-role guard. Inspect permissionMapper.deleteByObjectIds and the userRoleMapper deletion entry point before checking the transaction boundary. Done means deleting roles removes related permission and user_role rows, rejects the super role, and preserves admin access.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
authorization, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.