apache / apache/shenyu

[Task] Deprecated raw-password auth path still exported on public service interface

Open
#6,607 1 comment 0 reactions 0 assignees View on GitHub
admin: permission priority: medium type: refactor
Dominant language
Java
Stars
8.8k
Forks
3.1k
Avg merge
7d 1h
Merged PRs (30d)
85

Description

## Description
All three `@Deprecated` ("do not use … for authentication with raw passwords"). The impl still calls the mapper directly. `PasswordHashService` is the replacement but the raw-password entry point remains on a public service interface with no removal version.

## Location
```
shenyu-admin/.../mapper/DashboardUserMapper.java:69
.../service/DashboardUserService.java:91
.../service/impl/DashboardUserServiceImpl.java:266
```

## Impact
Misleading API surface; security-sensitive deprecation without removal target.

## Suggested fix
Set a removal version; gate the impl to delegate to `PasswordHashService`; or remove the public method.

## Related existing issue(s)
Adjacent to #5255/#4602 (closed password-security tasks) but this is the lingering deprecated public surface.

_Identified during the 2026-08-02 audit; full list in [`docs/issue-candidates-2026-08-02.md`](docs/issue-candidates-2026-08-02.md)._

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with DashboardUserMapper.java:69, DashboardUserService.java:91, and DashboardUserServiceImpl.java:266. Compare the deprecated raw-password path with PasswordHashService and review the related issues before choosing whether to set a removal version, delegate through the replacement, or remove the public method. Done means the selected policy is applied consistently to the public interface and implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
authentication, backend-api-design, security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.