apache / apache/shenyu

[Task] @Deprecated lock subsystem is still the wired production default

Open
#6,606 1 comment 0 reactions 0 assignees View on GitHub
admin priority: medium type: refactor
Dominant language
Java
Stars
8.8k
Forks
3.1k
Avg merge
7d 1h
Merged PRs (30d)
85

Description

## Description
The entire `shenyu-admin.lock` subsystem is `@Deprecated` ("Please use `JdbcLockRegistry#obtain` / `DefaultLockRepository`") but remains the live `@Bean`.

## Location
```
shenyu-admin.lock.RegisterExecutionLock.java:27
RegisterTransactionUtil.java:29
ForUpdateBackedRegisterExecutionLock.java:33
PlatformTransactionRegisterExecutionRepository.java:31
RegisterExecutionRepository.java:26
RegisterCenterConfiguration.java:79-80 (new PlatformTransactionRegisterExecutionRepository(...) as @Bean)
```

## Impact
Marking it deprecated while shipping it as default misleads both users and tooling — risk of "removing dead code" that is actually live.

## Suggested fix
Either migrate the bean to `JdbcLockRegistry`/`DefaultLockRepository` and delete the subsystem, or drop the `@Deprecated` until migration is real.

## Related existing issue(s)
None

_Identified during the 2026-08-02 audit; full list in [`docs/issue-candidates-2026-08-02.md`](docs/issue-candidates-2026-08-02.md)._

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at RegisterCenterConfiguration.java:79-80 and trace the @Bean through the listed shenyu-admin.lock classes. Compare that production wiring with JdbcLockRegistry#obtain and DefaultLockRepository before confirming with maintainers whether to migrate and remove the deprecated subsystem or remove its deprecation. Done means the chosen path is implemented consistently and the live default is no longer misleading.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, distributed-systems
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.