apache / apache/shenyu

[Task] Integration-test & k8s-ingress workflows are not required checks

Open
#6,597 1 comment 0 reactions 0 assignees View on GitHub
in: test priority: high type: build
Dominant language
Java
Stars
8.8k
Forks
3.1k
Avg merge
7d 1h
Merged PRs (30d)
85

Description

## Description
Branch protection (`.asf.yaml:35-37`) requires only 3 contexts (`check-license-header`, `build`, `e2e`). The `it`/`it-k8s` workflows have no `requirement` aggregation job and use `continue-on-error: true` + post-hoc shell exit — and aren't in the required list. A red `it`/`it-k8s` does not block merge.

## Location
```
.asf.yaml:35-37
.github/workflows/integrated-test.yml:174 (continue-on-error: true)
.github/workflows/integrated-test-k8s-ingress.yml:164
```

## Impact
dubbo/grpc/websocket/spring-cloud/rewrite/k8s-ingress integration regressions merge on green `build`+`e2e` alone.

## Suggested fix
Add `requirement` gate jobs (mirror `ci.yml:156-167`'s `always()` pattern) and add their contexts to `.asf.yaml`.

## Related existing issue(s)
None. #6432/#6435/#6437 are about concurrency canceling, not about missing required checks.

_Identified during the 2026-08-02 audit; full list in [`docs/issue-candidates-2026-08-02.md`](docs/issue-candidates-2026-08-02.md)._

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with .asf.yaml:35-37 and compare the required contexts with the jobs in .github/workflows/integrated-test.yml:174 and .github/workflows/integrated-test-k8s-ingress.yml:164. Read ci.yml:156-167 for the existing always() requirement pattern. Done means both integration workflows expose requirement gate contexts, those contexts are required in .asf.yaml, and failed integration checks block merging.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.