apache / apache/sedona

Optimize shellcheck ignores for actionlint pre-commit

Open
#2,738 9 comments 0 reactions 0 assignees View on GitHub
github_actions good first issue pre-commit shell
Dominant language
Java
Stars
2.4k
Forks
784
Avg merge
1d 12h
Merged PRs (30d)
58

Description

Original failed run seen here:

https://github.com/apache/sedona/actions/runs/22992869182/job/66757741342

This hook is here:

https://github.com/apache/sedona/blob/3ac639748416b8e6975a409e53bb571bc36a6343/.pre-commit-config.yaml#L510

So maybe we can remove some ignores and clean up the code ??

Contributor guide

Open the contributing guide

Research direction

Start with the failed workflow run and the actionlint hook in .pre-commit-config.yaml around line 510. Reproduce the pre-commit check, review which shellcheck ignores it reports, and determine which are still needed. Done means the unnecessary ignores and related cleanup are addressed without the hook failing.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.