apache / apache/royale-asjs

get rid of getLabelFromData in Basic renderers

Open
#303 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
ActionScript
Stars
380
Forks
120
PR merge metrics
No merged PRs in 30d

Description

This is all just-in-case code. There should be more renderer subclasses that grab the exact piece of data. getLabelFromData is better suited for Express.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating getLabelFromData and the Basic renderer subclasses. Read how those renderers obtain label data and compare that with the Express usage mentioned in the issue. Done means the unnecessary Basic-renderer helper is removed and the affected subclasses obtain their exact data directly, with relevant renderer tests still passing.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.