apache / apache/royale-asjs

DateChooser firstDayOfWeek is non functional

Open
#21 4 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
ActionScript
Stars
380
Forks
120
PR merge metrics
No merged PRs in 30d

Description

Most countries don't use Sunday as the first day of the week. Only USA, Canada, Japan and a few other do so. Setting the day of the week to be Monday like so doesn't seem to have any effect.

`model.firstDayOfWeek = 1;`

Looking at the setter it seems to me that it should be calling updateCalendar() (which it isn't) and perhaps changing model.dayNames to reflect the new order.

Even when dayName array is modified and updateCalendar is called manually there is still no effect. It looks like updateCalendar is missing code to take into account the first day of the week.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the DateChooser firstDayOfWeek setter and updateCalendar() to reproduce why changing the value does not affect the calendar. Check how model.dayNames is used when the calendar is rebuilt; done means Monday-first configuration changes the displayed week order and works with the reported model.firstDayOfWeek = 1 case.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.