apache / apache/rocketmq

[Enhancement] Fix Failing Tests In MessageStoreWithFilterTest

Open
#9,623 2 comments 0 reactions 0 assignees View on GitHub
type/enhancement
Dominant language
Java
Stars
22.6k
Forks
12k
Avg merge
2d 20h
Merged PRs (30d)
26

Description

### Before Creating the Enhancement Request

- [x] I have confirmed that this should be classified as an enhancement rather than a bug/feature.

### Summary

Image

In the original MessageStoreWithFilterTest class, when testing in a local Windows environment, MixAll's file deletion method failed to delete the commitlog files left over from previous tests. This caused tests to interfere with each other, leading to failures and inconsistent test results.

### Motivation

null

### Describe the Solution You'd Like

This pull request primarily aims to isolate the data for these tests, storing them in independent directories and releasing resources at the end, ensuring that local tests can pass.

### Describe Alternatives You've Considered

null

### Additional Context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the MessageStoreWithFilterTest class and inspect how its commitlog data is created and cleaned up, including MixAll's file deletion method. Isolate each test in an independent directory and verify resources are released at the end; done means the tests pass consistently in a local Windows environment without leftover data causing interference.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.