apache / apache/rocketmq

[Bug] GrpcClientChannel conversion failure logs raw gRPC Settings data

Open Beginner friendly
#10,720 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
22.6k
Forks
12k
Avg merge
3d 1h
Merged PRs (30d)
27

Description

## Problem

`GrpcClientChannel` logs raw gRPC Settings data when converting between Settings and channel extend attributes fails.

Evidence:
- `proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/channel/GrpcClientChannel.java` logs the full `settings` object in `toChannelExtendAttribute`.
- The same class logs the raw `attr` string in `parseChannelExtendAttribute`.

## Impact

This is in the RocketMQ Studio Track 2 / Proxy Admin diagnostics scope. Settings and serialized channel attributes can include detailed publish/subscription metadata, so conversion failure logs should avoid dumping them.

## Expected

Failure logs should keep enough context for diagnosis, such as client type, publish/subscription counts, and attribute length, without printing raw Settings or serialized attributes.

Contributor guide

Open the contributing guide

Research direction

Read proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/channel/GrpcClientChannel.java, focusing on toChannelExtendAttribute and parseChannelExtendAttribute. Compare the failure logs with the available client type, publish/subscription counts, and attribute length. Done means conversion failures retain diagnostic context without logging the raw settings object or serialized attr string.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.