apache / apache/rocketmq-spring

Make enableMsgTrace configurable with RocketMQMessageListener and ExtRocketMQTemplateConfiguration

Open
#548 3 comments 0 reactions 1 assignee Claimed by @Sunstreaker View on GitHub
enhancement good first issue
Dominant language
Java
Stars
2.3k
Forks
943
PR merge metrics
No merged PRs in 30d

Description

1. Please describe the feature you are requesting.
We want to make enableMsgTrace configurable through application.yml file as below.
@RocketMQMessageListener(
topic = "normal_topic_define_in_Aliware_MQ",
consumerGroup = "group_define_in_Aliware_MQ",
selectorExpression = "${demo.consumer.selector}",
enableMsgTrace = "${demo.consumer.enableMsgTrace}" // hope configure like this
)
public class ACLStringConsumer implements RocketMQListener {

@ExtRocketMQTemplateConfiguration(
nameServer = "${demo.rocketmq.extNameServer}",
tlsEnable = "${demo.rocketmq.ext.useTLS}",
enableMsgTrace = "${demo.consumer.enableMsgTrace}" // hope configure like this
)
public class ExtRocketMQTemplate extends RocketMQTemplate {
}

2. Provide any additional detail on your proposed use case for this feature.
enableMsg is important to identify the message source and consumer. But it may bring performance issue. We don't want to turn off the feature totally through server side configuration. We want to control it from producer client or consumer client when we met performance issue indeed.

3. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
should-have.
No workaround, we have to hard code true or false in RocketMQMessageListener and ExtRocketMQTemplateConfiguration annotation.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.