apache / apache/rocketmq-spring

@AutoConfigureAfter({MessageConverterConfiguration.class}) and @AutoConfigureBefore({RocketMQTransactionConfiguration.class}) not take effect,They are incorrect usage

Open
#501 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
2.3k
Forks
943
PR merge metrics
No merged PRs in 30d

Description

**BUG REPORT**
1. Please describe the issue you observed:
![1668228610407](https://user-images.githubusercontent.com/57820276/201457653-565c4fdc-de4a-403b-b2c9-718d786ce974.png)
@AutoConfigureAfter({MessageConverterConfiguration.class})and@AutoConfigureBefore({RocketMQTransactionConfiguration.class})
not take effect , They are incorrect usage.
2. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):
@AutoConfigureAfter and @AutoConfigureBefore, only the autoConfiguration classes under spring.factories will be sorted.
MessageConverterConfiguration.class and RocketMQTransactionConfiguration.class not under spring.factories , so, They are incorrect usage.
i want to delete it to fix this problem.
3. Influence
now , It will not affect the function as a whole. but when someone read it or learn it and they think it's right.They will also write this in their own projects , this is not a good behavior.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.