apache / apache/rocketmq-externals

Is DefaultMQPullConsumer use RmqProducerGroup correct in ConnectUtil class?

Open
#803 2 comments 0 reactions 0 assignees View on GitHub
discuss
Dominant language
Java
Stars
4.6k
Forks
3k
Avg merge
2h 33m
Merged PRs (30d)
1

Description

line 87 in ConnectUtil
```java

public static DefaultMQProducer initDefaultMQProducer(ConnectConfig connectConfig) {
DefaultMQProducer producer = new DefaultMQProducer();
producer.setNamesrvAddr(connectConfig.getNamesrvAddr());
producer.setInstanceName(createInstance(connectConfig.getNamesrvAddr()));
producer.setProducerGroup(createGroupNameV2(connectConfig.getRmqProducerGroup()));
producer.setSendMsgTimeout(connectConfig.getOperationTimeout());
producer.setMaxMessageSize(RuntimeConfigDefine.MAX_MESSAGE_SIZE);
producer.setLanguage(LanguageCode.JAVA);
return producer;
}

public static DefaultMQPullConsumer initDefaultMQPullConsumer(ConnectConfig connectConfig) {
DefaultMQPullConsumer consumer = new DefaultMQPullConsumer();
consumer.setNamesrvAddr(connectConfig.getNamesrvAddr());
consumer.setInstanceName(createInstance(connectConfig.getNamesrvAddr()));
87 consumer.setConsumerGroup(createGroupNameV2(connectConfig.getRmqProducerGroup()));
consumer.setMaxReconsumeTimes(connectConfig.getRmqMaxRedeliveryTimes());
consumer.setBrokerSuspendMaxTimeMillis(connectConfig.getBrokerSuspendMaxTimeMillis());
consumer.setConsumerPullTimeoutMillis((long) connectConfig.getRmqMessageConsumeTimeout());
return consumer;
}
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at ConnectUtil line 87 and read the related ConnectConfig fields and call sites. Compare how the producer and pull consumer groups are configured, then verify the expected RocketMQ consumer-group behavior; done means the intended group setting is confirmed or the issue has a clearly scoped correction.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, distributed-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.