apache / apache/rocketmq-externals

[rocketmq-flink]pendingOffsetsToCommit in RocketMQSource is not used anywhere

Open
#433 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
4.6k
Forks
3k
Avg merge
2h 33m
Merged PRs (30d)
1

Description

RocketMQSource defines a variable pendingOffsetsToCommit as

`private LinkedMap pendingOffsetsToCommit;`

But I didn't find real use of it, can it be removed?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the RocketMQSource class and inspect the declaration and references of pendingOffsetsToCommit. Confirm that the field has no uses, remove the unused declaration, and run the project's relevant checks to verify the source still builds and tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.