apache / apache/rocketmq-exporter

Polish according to Prometheus rules

Open
#1 0 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
324
Forks
178
PR merge metrics
No merged PRs in 30d

Description

If possible use counters rather than gauges.

rocketmq_producer_put_size is missing units, and as a counter should end in _total.

rocketmq_group_get_latency is missing a unit and should be a Summary without quantiles if possible.

cluster and broker sound like target labels, which should come from Prometheus rather than the exporter.

Your port number isn't in the usual range from the wiki page.

More details see https://prometheus.io/docs/instrumenting/writing_exporters/

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.