apache / apache/rocketmq-dashboard

Add regression coverage for runtime data-mode service

Open Beginner friendly
#4,036 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1.4k
Forks
683
Avg merge
2d 12h
Merged PRs (30d)
62

Description

## Problem
The current test suite does not cover runtime data-mode service.

## Expected behavior
- A focused Vitest case locks the existing behavior.
- The targeted test file passes and fails if the covered behavior regresses.

## Scope
Only add regression coverage for $(@{Slug=data-mode; Focus=runtime data-mode service; PrTitle=test(data-mode): cover the runtime data-mode service; TestFile=web/src/services/__tests__/dataMode.test.ts; Mode=new; Append=/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import { afterEach, describe, expect, it } from 'vitest';
import { useDataModeStore } from '../../stores/dataModeStore';
import { isMockMode } from '../dataMode';

describe('dataMode service', () => {
afterEach(() => {
useDataModeStore.setState({ useMock: false });
localStorage.clear();
});

it('reflects the runtime mock-data store flag', () => {
useDataModeStore.setState({ useMock: true });
expect(isMockMode()).toBe(true);

useDataModeStore.setState({ useMock: false });
expect(isMockMode()).toBe(false);
});
});}.TestFile). No runtime behavior changes.

## Acceptance criteria
- [ ] The targeted Vitest file passes.
- [ ] git diff --check is clean.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with web/src/services/dataMode and web/src/stores/dataModeStore, then add the focused test at web/src/services/__tests__/dataMode.test.ts. Run the targeted Vitest file; done means the runtime data-mode behavior is covered, the test passes, and git diff --check is clean.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.