apache / apache/rocketmq-dashboard

Add regression coverage for agent engine store persistence and migration

Open Beginner friendly
#4,034 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1.4k
Forks
683
Avg merge
2d 14h
Merged PRs (30d)
58

Description

## Problem
The current test suite does not cover agent engine store persistence and migration.

## Expected behavior
- A focused Vitest case locks the existing behavior.
- The targeted test file passes and fails if the covered behavior regresses.

## Scope
Only add regression coverage for $(@{Slug=engine-store; Focus=agent engine store persistence and migration; PrTitle=test(ai-engine): cover agent engine persistence and migration; TestFile=web/src/stores/__tests__/engineStore.test.ts; Mode=new; Append=/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import { afterEach, describe, expect, it, vi } from 'vitest';

const STORAGE_KEY = 'rocketmq-studio-agent-engine';

async function loadStore(persistedEngine?: string, persistedVersion = 1) {
vi.resetModules();
if (persistedEngine !== undefined) {
localStorage.setItem(
STORAGE_KEY,
JSON.stringify({ state: { engine: persistedEngine }, version: persistedVersion }),
);
}
return (await import('../engineStore')).useEngineStore;
}

describe('engineStore', () => {
afterEach(() => {
vi.resetModules();
localStorage.clear();
});

it('defaults to claude-code when no preference is persisted', async () => {
const store = await loadStore();
expect(store.getState().engine).toBe('claude-code');
});

it('restores a persisted supported engine', async () => {
const store = await loadStore('qoder');
expect(store.getState().engine).toBe('qoder');
});

it('updates the persisted engine through the action', async () => {
const store = await loadStore('claude-code');
store.getState().setEngine('http');
expect(store.getState().engine).toBe('http');
});

it('migrates stale persisted engines back to claude-code', async () => {
const store = await loadStore('stale-engine', 0);
expect(store.getState().engine).toBe('claude-code');
});
});}.TestFile). No runtime behavior changes.

## Acceptance criteria
- [ ] The targeted Vitest file passes.
- [ ] git diff --check is clean.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with web/src/stores/__tests__/engineStore.test.ts and inspect the imported ../engineStore implementation to understand its persistence and migration behavior. Run the targeted Vitest file, covering the stated default, restore, update, and migration cases. Done means the targeted test passes and git diff --check is clean.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
85/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.