apache / apache/rocketmq-client-go

Unable to get SubscriptionMessageQueues

Open
#1,048 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1.4k
Forks
445
PR merge metrics
No merged PRs in 30d

Description

https://github.com/apache/rocketmq-client-go/blob/1d86ea68616504c6985586d2a9bd1d47c312246f/examples/consumer/pull/pull_from/main.go#L95

I'm going to implement an example of `pull_from`, I found related example in `examples` file.
But I have a doubt, why use the `FetchPublishMessageQueues` method?
`FetchSubscriptionMessageQueues` should not be used to fetch consumer queues.

Publish and Subscribe Queues should be two different queues.

But `Admin` does not provide the `FetchSubscriptionMessageQueues` interface, I think it is necessary to provide an interface to get the consumer queue.
https://github.com/apache/rocketmq-client-go/blob/1d86ea68616504c6985586d2a9bd1d47c312246f/admin/admin.go#LL33C6-L33C6
![image](https://user-images.githubusercontent.com/46491088/236746979-c9d73b95-277b-4674-9134-46c923b7da31.png)

Do we need to add `FetchSubscribeMessageQueues` method in `Admin`, or do we take other methods.
```
func (a *admin) FetchSubscribeMessageQueues(ctx context.Context, topic string) ([]*primitive.MessageQueue, error) {
return a.cli.GetNameSrv().FetchSubscribeMessageQueues(utils.WrapNamespace(a.opts.Namespace, topic))
}
```

Looking forward to your reply, thank you.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.