Clean up methods used to create ack command
- Dominant language
- Java
- Stars
- 15.3k
- Forks
- 3.8k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 160
Description
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
### Motivation
Now we have 8 methods to create an ack command. We should consider to check which one is redundant.
See more details at https://github.com/apache/pulsar/pull/21419.
### Solution
Only keep `public static ByteBuf newMultiMessageAck(long consumerId, TxnID txnID,
List> entries, long requestID) ` and mark other methods as deprecated.
### Alternatives
_No response_
### Anything else?
_No response_
### Are you willing to submit a PR?
- [X] I'm willing to submit a PR!
Contributor guide
Research direction
Review PR #21419 and locate the eight methods used to create ack commands, starting with newMultiMessageAck(long consumerId, TxnID txnID, List> entries, long requestID). Compare their call sites and API usage; done means only the specified method remains non-deprecated and the redundant methods are marked deprecated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100